linux-kernel - Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154278766192.88331.16232130563413450456@swboyd.mtv.corp.google.com>
Date:   Wed, 21 Nov 2018 00:07:41 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Nicolas Boichat <drinkcat@...omium.org>,
        Weiyi Lu <weiyi.lu@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>, sboyd@...eaurora.org,
        Rob Herring <robh@...nel.org>, jamesjj.liao@...iatek.com,
        fan.chen@...iatek.com,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        lkml <linux-kernel@...r.kernel.org>,
        linux-mediatek@...ts.infradead.org, linux-clk@...r.kernel.org,
        srv_heupstream@...iatek.com, owen.chen@...iatek.com,
        mars.cheng@...iatek.com
Subject: Re: [PATCH v1 04/11] soc: mediatek: add new flow for mtcmos power.

Quoting Weiyi Lu (2018-11-19 18:37:34)
> On Tue, 2018-11-13 at 11:31 -0800, Nicolas Boichat wrote:
> > On Mon, Nov 5, 2018 at 10:42 PM Weiyi Lu <weiyi.lu@...iatek.com> wrote:

> > > @@ -226,6 +397,7 @@ static int scpsys_power_on(struct generic_pm_domain *genpd)
> > >         if (ret < 0)
> > >                 goto err_pwr_ack;
> > >
> > > +
> > 
> > Drop this.
> Why do we try to drop this? Once the power-on step fail, the following
> steps should not be permitted.

I just see a whitespace addition that doesn't do anything. I suspect
it's a style nitpick and common practice to not include spurious diffs
in the patch. So remove this hunk?