linux-kernel - RE: [PATCH v2] x86: modernize sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5BF5577202000078001FE7AC@prv1-mh.provo.novell.com>
Date:   Wed, 21 Nov 2018 06:02:42 -0700
From:   "Jan Beulich" <JBeulich@...e.com>
To:     "David Laight" <David.Laight@...LAB.COM>
Cc:     <mingo@...e.hu>, <tglx@...utronix.de>,
        "Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
        "Juergen Gross" <jgross@...e.com>, <linux-kernel@...r.kernel.org>,
        <hpa@...or.com>
Subject: RE: [PATCH v2] x86: modernize sync_bitops.h

>>> On 21.11.18 at 12:55, <David.Laight@...LAB.COM> wrote:
> From: Jan Beulich
>> Sent: 21 November 2018 10:11
>> 
>> Add missing insn suffixes and use rmwcc.h just like was (more or less)
>> recently done for bitops.h as well.
> 
> Why? bts (etc) on memory don't really have an 'operand size'.

Of course they do - depending on operand size they operate on
2-, 4-, or 8-byte quantities. When the second operand is a
register, the suffix is redundant (but doesn't hurt), but when
the second operand is an immediate, the assembler (in AT&T
syntax) has no way of knowing what operand size you mean.

Jan