linux-kernel - Re: [PATCH AUTOSEL 4.19 09/36] scsi: NCR5380: Return false instead of NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.21.1811230849180.305@nippy.intranet>
Date:   Fri, 23 Nov 2018 08:49:39 +1100 (AEDT)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Sasha Levin <sashal@...nel.org>
cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 09/36] scsi: NCR5380: Return false instead
 of NULL


This patch is not relevant to any -stable branch. Please don't backport.

-- 

On Thu, 22 Nov 2018, Sasha Levin wrote:

> From: Finn Thain <fthain@...egraphics.com.au>
> 
> [ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ]
> 
> I overlooked this statement when I recently converted the function result
> type from struct scsi_cmnd * to bool. No change to object code.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/scsi/NCR5380.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 90ea0f5d9bdb..fbcbd6db371f 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1190,7 +1190,7 @@ static struct scsi_cmnd *NCR5380_select(struct Scsi_Host *instance,
>  
>  out:
>  	if (!hostdata->selecting)
> -		return NULL;
> +		return false;
>  	hostdata->selecting = NULL;
>  	return cmd;
>  }
>