| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20181122084815.GA84118@gmail.com>
Date: Thu, 22 Nov 2018 09:48:15 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Yi Wang <wang.yi59@....com.cn>
Cc: tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
x86@...nel.org, linux-kernel@...r.kernel.org,
ard.biesheuvel@...aro.org, linux-efi@...r.kernel.org,
pbonzini@...hat.com, rkrcmar@...hat.com, kvm@...r.kernel.org,
jgross@...e.com, akataria@...are.com,
virtualization@...ts.linux-foundation.org, m.mizuma@...fujitsu.com,
peterz@...radead.org, prarit@...hat.com, douly.fnst@...fujitsu.com,
dwmw@...zon.co.uk, luto@...nel.org, pasha.tatashin@...cle.com,
rajvi.jingar@...el.com, zhe.he@...driver.com,
akpm@...ux-foundation.org, dyoung@...hat.com,
takahiro.akashi@...aro.org, ebiederm@...ssion.com, bhe@...hat.com,
ivan.gorinov@...el.com, robh@...nel.org, andy.shevchenko@...il.com,
frank.rowand@...y.com, jan.kiszka@...mens.com,
jailhouse-dev@...glegroups.com, konrad.wilk@...cle.com,
thomas.lendacky@....com, pravin.shedge4linux@...il.com,
namit@...are.com, jroedel@...e.de, bhelgaas@...gle.com,
linux-pci@...r.kernel.org, keescook@...omium.org, anton@...msg.org,
ccross@...roid.com, tony.luck@...el.com, rostedt@...dmis.org,
kexec@...ts.infradead.org, robh+dt@...nel.org,
frowand.list@...il.com, devicetree@...r.kernel.org,
oleg@...hat.com, zhong.weidong@....com.cn, up2wing@...il.com
Subject: Re: [PATCH] x86: fix -Wmissing-prototypes warning
* Yi Wang <wang.yi59@....com.cn> wrote:
> We may get -Wmissing-prototypes warnings when building
> kernel with W=1, it's better to fix them as global function
> signature can be changed and caller who use the old unchanged
> prototypes will be hosed.
>
> This patch fixes most of -Wmissing-prototypes warnings which
> are in the root directory of arch/x86/kernel, not including
> the subdirectories.
>
> These are the warnings fixed in this patch:
> arch/x86/kernel/signal.c:865:17: warning: no previous prototype for ‘sys32_x32_rt_sigreturn’ [-Wmissing-prototypes]
> arch/x86/kernel/signal_compat.c:164:6: warning: no previous prototype for ‘sigaction_compat_abi’ [-Wmissing-prototypes]
> arch/x86/kernel/traps.c:625:46: warning: no previous prototype for ‘sync_regs’ [-Wmissing-prototypes]
> arch/x86/kernel/traps.c:640:24: warning: no previous prototype for ‘fixup_bad_iret’ [-Wmissing-prototypes]
> arch/x86/kernel/traps.c:929:13: warning: no previous prototype for ‘trap_init’ [-Wmissing-prototypes]
> arch/x86/kernel/irq.c:270:28: warning: no previous prototype for ‘smp_x86_platform_ipi’ [-Wmissing-prototypes]
> arch/x86/kernel/irq.c:301:16: warning: no previous prototype for ‘smp_kvm_posted_intr_ipi’ [-Wmissing-prototypes]
> arch/x86/kernel/irq.c:314:16: warning: no previous prototype for ‘smp_kvm_posted_intr_wakeup_ipi’ [-Wmissing-prototypes]
> arch/x86/kernel/irq.c:328:16: warning: no previous prototype for ‘smp_kvm_posted_intr_nested_ipi’ [-Wmissing-prototypes]
> arch/x86/kernel/irq_work.c:16:28: warning: no previous prototype for ‘smp_irq_work_interrupt’ [-Wmissing-prototypes]
> arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes]
> arch/x86/kernel/quirks.c:672:13: warning: no previous prototype for ‘early_platform_quirks’ [-Wmissing-prototypes]
> arch/x86/kernel/tsc.c:1499:15: warning: no previous prototype for ‘calibrate_delay_is_known’ [-Wmissing-prototypes]
> arch/x86/kernel/process.c:653:13: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes]
> arch/x86/kernel/process.c:717:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes]
> arch/x86/kernel/process.c:784:6: warning: no previous prototype for ‘do_arch_prctl_common’ [-Wmissing-prototypes]
> arch/x86/kernel/reboot.c:869:6: warning: no previous prototype for ‘nmi_panic_self_stop’ [-Wmissing-prototypes]
> arch/x86/kernel/smp.c:176:27: warning: no previous prototype for ‘smp_reboot_interrupt’ [-Wmissing-prototypes]
> arch/x86/kernel/smp.c:260:28: warning: no previous prototype for ‘smp_reschedule_interrupt’ [-Wmissing-prototypes]
> arch/x86/kernel/smp.c:281:28: warning: no previous prototype for ‘smp_call_function_interrupt’ [-Wmissing-prototypes]
> arch/x86/kernel/smp.c:291:28: warning: no previous prototype for ‘smp_call_function_single_interrupt’ [-Wmissing-prototypes]
> arch/x86/kernel/ftrace.c:840:6: warning: no previous prototype for ‘arch_ftrace_update_trampoline’ [-Wmissing-prototypes]
> arch/x86/kernel/ftrace.c:934:7: warning: no previous prototype for ‘arch_ftrace_trampoline_func’ [-Wmissing-prototypes]
> arch/x86/kernel/ftrace.c:946:6: warning: no previous prototype for ‘arch_ftrace_trampoline_free’ [-Wmissing-prototypes]
> arch/x86/kernel/crash.c:114:6: warning: no previous prototype for ‘crash_smp_send_stop’ [-Wmissing-prototypes]
> arch/x86/kernel/crash.c:351:5: warning: no previous prototype for ‘crash_setup_memmap_entries’ [-Wmissing-prototypes]
> arch/x86/kernel/crash.c:424:5: warning: no previous prototype for ‘crash_load_segments’ [-Wmissing-prototypes]
> arch/x86/kernel/machine_kexec_64.c:372:7: warning: no previous prototype for ‘arch_kexec_kernel_image_load’ [-Wmissing-prototypes]
> arch/x86/kernel/paravirt-spinlocks.c:12:16: warning: no previous prototype for ‘__native_queued_spin_unlock’ [-Wmissing-prototypes]
> arch/x86/kernel/paravirt-spinlocks.c:18:6: warning: no previous prototype for ‘pv_is_native_spin_unlock’ [-Wmissing-prototypes]
> arch/x86/kernel/paravirt-spinlocks.c:24:16: warning: no previous prototype for ‘__native_vcpu_is_preempted’ [-Wmissing-prototypes]
> arch/x86/kernel/paravirt-spinlocks.c:30:6: warning: no previous prototype for ‘pv_is_native_vcpu_is_preempted’ [-Wmissing-prototypes]
> arch/x86/kernel/kvm.c:258:1: warning: no previous prototype for ‘do_async_page_fault’ [-Wmissing-prototypes]
> arch/x86/kernel/jailhouse.c:200:6: warning: no previous prototype for ‘jailhouse_paravirt’ [-Wmissing-prototypes]
> arch/x86/kernel/check.c:91:13: warning: no previous prototype for ‘setup_bios_corruption_check’ [-Wmissing-prototypes]
> arch/x86/kernel/check.c:139:6: warning: no previous prototype for ‘check_for_bios_corruption’ [-Wmissing-prototypes]
> arch/x86/kernel/devicetree.c:32:13: warning: no previous prototype for ‘early_init_dt_scan_chosen_arch’ [-Wmissing-prototypes]
> arch/x86/kernel/devicetree.c:42:13: warning: no previous prototype for ‘add_dtb’ [-Wmissing-prototypes]
> arch/x86/kernel/devicetree.c:108:6: warning: no previous prototype for ‘x86_of_pci_init’ [-Wmissing-prototypes]
> arch/x86/kernel/devicetree.c:314:13: warning: no previous prototype for ‘x86_dtb_init’ [-Wmissing-prototypes]
> arch/x86/kernel/tracepoint.c:16:5: warning: no previous prototype for ‘trace_pagefault_reg’ [-Wmissing-prototypes]
> arch/x86/kernel/tracepoint.c:22:6: warning: no previous prototype for ‘trace_pagefault_unreg’ [-Wmissing-prototypes]
> arch/x86/kernel/head64.c:113:22: warning: no previous prototype for ‘__startup_64’ [-Wmissing-prototypes]
> arch/x86/kernel/head64.c:262:15: warning: no previous prototype for ‘__startup_secondary_64’ [-Wmissing-prototypes]
> arch/x86/kernel/head64.c:350:12: warning: no previous prototype for ‘early_make_pgtable’ [-Wmissing-prototypes]
>
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> ---
> arch/x86/include/asm/crash.h | 1 +
> arch/x86/include/asm/efi.h | 2 --
> arch/x86/include/asm/irq.h | 7 +++++++
> arch/x86/include/asm/irq_work.h | 1 +
> arch/x86/include/asm/kvm_para.h | 1 +
> arch/x86/include/asm/paravirt.h | 5 +++++
> arch/x86/include/asm/reboot.h | 1 +
> arch/x86/include/asm/setup.h | 5 +++++
> arch/x86/include/asm/sighandling.h | 5 +++++
> arch/x86/include/asm/smp.h | 6 ++++++
> arch/x86/include/asm/traps.h | 4 ++++
> arch/x86/include/asm/tsc.h | 1 +
> arch/x86/kernel/check.c | 3 ++-
> arch/x86/kernel/crash.c | 1 +
> arch/x86/kernel/devicetree.c | 1 +
> arch/x86/kernel/jailhouse.c | 1 +
> arch/x86/kernel/process.c | 3 +++
> arch/x86/kernel/quirks.c | 1 +
> arch/x86/kernel/tracepoint.c | 1 +
> include/linux/efi.h | 2 ++
> include/linux/ftrace.h | 3 +++
> include/linux/kexec.h | 1 +
> include/linux/of_fdt.h | 1 +
> include/linux/ptrace.h | 1 +
> 24 files changed, 55 insertions(+), 3 deletions(-)
Breaks 32-bit compilation:
./arch/x86/include/asm/setup.h: Assembler messages:
./arch/x86/include/asm/setup.h:30: Error: no such instruction: `unsigned long __startup_64(unsigned long physaddr,struct boot_params *bp)'
I'll skip the setup.h bits - let's hope that's the only bug.
Thanks,
Ingo
Powered by blists - more mailing lists