linux-kernel - Re: [PATCH] soc/tegra: Fix terminating condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Nov 2018 09:50:22 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] soc/tegra: Fix terminating condition

On Thu, Nov 22, 2018 at 12:52:44AM -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/soc/tegra/common.c:27:16: error: address of array
> 'match->compatible' will always evaluate to 'true'
> [-Werror,-Wpointer-bool-conversion]
>         while (match->compatible) {
>         ~~~~~  ~~~~~~~^~~~~~~~~~
> 1 error generated.
> 
> Whoops, we have an infinite loop and QEMU no longer boots...
> 
> https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/160242918
> 
> Check that the first character of the string isn't null so that the loop
> properly terminates.
> 
> Fixes: c57eff9503a5 ("soc/tegra: refactor soc_is_tegra()")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/soc/tegra/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Wow... that's what I get from not testing this properly. Apologies for
the inconvenience.

Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)