linux-kernel - Re: [PATCH] dt-bindings: i2c: Use correct vendor prefix for Atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <374af1fb-54bc-ee13-b4fd-616c2fe0746f@axentia.se>
Date:   Fri, 23 Nov 2018 12:40:19 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Thierry Reding <thierry.reding@...il.com>,
        Rob Herring <robh+dt@...nel.org>
CC:     Wolfram Sang <wsa@...-dreams.de>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: i2c: Use correct vendor prefix for Atmel

On 2018-11-23 13:10, Thierry Reding wrote:
> From: Thierry Reding <treding@...dia.com>
> 
> The "at," prefix was never correct for Atmel, so fix the few occurrences
> that got it wrong. Use "atmel," instead.

Fully agreed. However, given that atmel,24c08 is documented in .../eeprom/at24.txt
I think it would be better to remove at,24c08 from trivial-devices.txt

Cheers,
Peter

> Signed-off-by: Thierry Reding <treding@...dia.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-mux-ltc4306.txt | 2 +-
>  Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 2 +-
>  Documentation/devicetree/bindings/i2c/nxp,pca9541.txt     | 2 +-
>  Documentation/devicetree/bindings/trivial-devices.txt     | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-ltc4306.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-ltc4306.txt
> index 1e98c6b3a721..c661b9083ec6 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-ltc4306.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-ltc4306.txt
> @@ -43,7 +43,7 @@ Example:
>  			reg = <0>;
>  
>  			eeprom@50 {
> -				compatible = "at,24c02";
> +				compatible = "atmel,24c02";
>  				reg = <0x50>;
>  			};
>  		};
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index ccf6c86ed076..30ac6a60f041 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -54,7 +54,7 @@ Example:
>  			reg = <2>;
>  
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> diff --git a/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt b/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
> index 0fbbc6970ec5..42bfc09c8918 100644
> --- a/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
> +++ b/Documentation/devicetree/bindings/i2c/nxp,pca9541.txt
> @@ -22,7 +22,7 @@ Example:
>  			#size-cells = <0>;
>  
>  			eeprom@54 {
> -				compatible = "at,24c08";
> +				compatible = "atmel,24c08";
>  				reg = <0x54>;
>  			};
>  		};
> diff --git a/Documentation/devicetree/bindings/trivial-devices.txt b/Documentation/devicetree/bindings/trivial-devices.txt
> index 6ab001fa1ed4..b7a7eaf2979a 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/trivial-devices.txt
> @@ -21,7 +21,7 @@ adi,adt7490		+/-1C TDM Extended Temp Range I.C
>  adi,adxl345		Three-Axis Digital Accelerometer
>  adi,adxl346		Three-Axis Digital Accelerometer (backward-compatibility value "adi,adxl345" must be listed too)
>  ams,iaq-core		AMS iAQ-Core VOC Sensor
> -at,24c08		i2c serial eeprom  (24cxx)
> +atmel,24c08		i2c serial eeprom  (24cxx)
>  atmel,at97sc3204t	i2c trusted platform module (TPM)
>  capella,cm32181		CM32181: Ambient Light Sensor
>  capella,cm3232		CM3232: Ambient Light Sensor
>