linux-kernel - Re: [PATCH net-next v3 4/4] enetc: Add RFS and RSS support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 25 Nov 2018 15:28:54 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Claudiu Manoil <claudiu.manoil@....com>
Cc:     kbuild-all@...org, "David S . Miller" <davem@...emloft.net>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexandru.marginean@....com, catalin.horghidan@....com
Subject: Re: [PATCH net-next v3 4/4] enetc: Add RFS and RSS support

Hi Claudiu,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Claudiu-Manoil/Introduce-ENETC-ethernet-drivers/20181124-111823
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/freescale/enetc/enetc_hw.h:310:16: warning: cast to restricted __le64

vim +310 drivers/net/ethernet/freescale/enetc/enetc_hw.h

58399e118 Claudiu Manoil 2018-11-23  292  
58399e118 Claudiu Manoil 2018-11-23  293  /* general register accessors */
58399e118 Claudiu Manoil 2018-11-23  294  #define enetc_rd_reg(reg)	ioread32((reg))
58399e118 Claudiu Manoil 2018-11-23  295  #define enetc_wr_reg(reg, val)	iowrite32((val), (reg))
7b02f2a09 Claudiu Manoil 2018-11-23  296  #ifdef ioread64
7b02f2a09 Claudiu Manoil 2018-11-23  297  #define enetc_rd_reg64(reg)	ioread64((reg))
7b02f2a09 Claudiu Manoil 2018-11-23  298  #else
7b02f2a09 Claudiu Manoil 2018-11-23  299  /* using this to read out stats on 32b systems */
7b02f2a09 Claudiu Manoil 2018-11-23  300  static inline u64 enetc_rd_reg64(void __iomem *reg)
7b02f2a09 Claudiu Manoil 2018-11-23  301  {
7b02f2a09 Claudiu Manoil 2018-11-23  302  	u32 low, high, tmp;
7b02f2a09 Claudiu Manoil 2018-11-23  303  
7b02f2a09 Claudiu Manoil 2018-11-23  304  	do {
7b02f2a09 Claudiu Manoil 2018-11-23  305  		high = ioread32(reg + 4);
7b02f2a09 Claudiu Manoil 2018-11-23  306  		low = ioread32(reg);
7b02f2a09 Claudiu Manoil 2018-11-23  307  		tmp = ioread32(reg + 4);
7b02f2a09 Claudiu Manoil 2018-11-23  308  	} while (high != tmp);
7b02f2a09 Claudiu Manoil 2018-11-23  309  
7b02f2a09 Claudiu Manoil 2018-11-23 @310  	return le64_to_cpu((u64)high << 32 | low);
7b02f2a09 Claudiu Manoil 2018-11-23  311  }
7b02f2a09 Claudiu Manoil 2018-11-23  312  #endif
58399e118 Claudiu Manoil 2018-11-23  313  

:::::: The code at line 310 was first introduced by commit
:::::: 7b02f2a0900df6d70fa9ddc8f4cb9a438db6e115 enetc: Add ethtool statistics

:::::: TO: Claudiu Manoil <claudiu.manoil@....com>
:::::: CC: 0day robot <lkp@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (66614 bytes)