linux-kernel - Re: linux-next: build warning after merge of the f2fs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181126215924.GA55960@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 26 Nov 2018 13:59:24 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Kees Cook <keescook@...gle.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the f2fs tree

Hi Stephen,

On 11/26, Stephen Rothwell wrote:
> Hi Jaegeuk,
> 
> After merging the f2fs tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
> 
> In file included from fs/f2fs/dir.c:11:
> fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
> fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (set)
>       ^
> fs/f2fs/f2fs.h:2390:2: note: here
>   case FI_DATA_EXIST:
>   ^~~~
> 
> Exposed by my use of -Wimplicit-fallthrough
> 
> I am not sure why this has turned up now (as opposed to earlier today).

The above change had been there for a long time, as an intended behavior.
Hmm, I'm not sure how to avoid this.

Thanks,

> 
> -- 
> Cheers,
> Stephen Rothwell