linux-kernel - Re: linux-next: Signed-off-by missing for commit in the kselftest tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181128092735.7a2f830f@canb.auug.org.au>
Date:   Wed, 28 Nov 2018 09:27:35 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     shuah <shuah@...nel.org>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Rue <dan.rue@...aro.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the kselftest
 tree

Hi Shuah,

On Tue, 27 Nov 2018 14:17:57 -0700 shuah <shuah@...nel.org> wrote:
>
> Thanks for catching this. I will fix it. This is the result of change 
> log content messing up the commit: The diff -Z in the change log 
> resulted in throwing out the Signed-off and Acked-by.

Tricky :-(

> -----------------------------------------------------------------
> diff -Z is used to trim the trailing whitespace when comparing the
> loaded firmware file with the source firmware file. However, per the
> comment in the source code, -Z should not be necessary. In testing, the
> input and output files are identical.
> 
> Additionally, -Z is not a standard option and is not available in
> environments such as busybox. When -Z is not supported, diff fails with
> a usage error, which is suppressed, but then causes read_firmwares() to
> exit with a false failure message.
> --------------------------------------------------------------------
> 
> Oh well! I will fix-up the change-log and amend the commit.

Thanks.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped