linux-kernel - Re: linux-next: Signed-off-by missing for commit in the kselftest tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6235956e-5edd-3b7d-1898-ab55094a7e16@kernel.org>
Date:   Tue, 27 Nov 2018 14:17:57 -0700
From:   shuah <shuah@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Rue <dan.rue@...aro.org>, shuah@...nel.org
Subject: Re: linux-next: Signed-off-by missing for commit in the kselftest
 tree

On 11/27/18 1:36 PM, Stephen Rothwell wrote:
> Hi Shuah,
> 
> Commit
> 
>    623ea0df7083 ("selftests: firmware: remove use of non-standard diff -Z option")
> 
> is missing a Signed-off-by from its author.
> 

Thanks for catching this. I will fix it. This is the result of change 
log content messing up the commit: The diff -Z in the change log 
resulted in throwing out the Signed-off and Acked-by.

-----------------------------------------------------------------
diff -Z is used to trim the trailing whitespace when comparing the
loaded firmware file with the source firmware file. However, per the
comment in the source code, -Z should not be necessary. In testing, the
input and output files are identical.

Additionally, -Z is not a standard option and is not available in
environments such as busybox. When -Z is not supported, diff fails with
a usage error, which is suppressed, but then causes read_firmwares() to
exit with a false failure message.
--------------------------------------------------------------------

Oh well! I will fix-up the change-log and amend the commit.

thanks,
-- Shuah