linux-kernel - Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181127085742.GG4272@dell>
Date:   Tue, 27 Nov 2018 08:57:42 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Pascal PAILLET-LME <p.paillet@...com>
Cc:     "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        "benjamin.gaignard@...aro.org" <benjamin.gaignard@...aro.org>,
        "eballetbo@...il.com" <eballetbo@...il.com>,
        "axel.lin@...ics.com" <axel.lin@...ics.com>
Subject: Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote:
> Hi Lee,
> I have just one question regarding i2c_device_id.

Don't forget to trim your responses.

Lots of unrequired quotes here.

[...]

> >> +static const struct i2c_device_id stpmic1_id[] = {
> >> +	{ "stpmic1"},
> >> +	{}
> >> +};
> > I don't think this is required any more.
> should I replace with the following ?
> 
> static const struct of_device_id stpmic1_of_match[] = {
>      { .compatible = "st,stpmic1", },
>      {},
> };
> MODULE_DEVICE_TABLE(of, stpmic1_of_match);

I think it should have had that already.  So yes, please.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog