linux-kernel - Re: [RFC PATCH] net: macb: Apply RXUBR workaround only to versions with errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b550305-ff96-fdf6-883e-b6ae69ad3124@ni.com>
Date:   Wed, 28 Nov 2018 21:09:35 +0000
From:   Brandon Streiff <brandon.streiff@...com>
To:     Harini Katakam <harini.katakam@...inx.com>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "harinikatakamlinux@...il.com" <harinikatakamlinux@...il.com>
Subject: Re: [RFC PATCH] net: macb: Apply RXUBR workaround only to versions
 with errata

On 11/23/2018 3:59 AM, Harini Katakam wrote:
> +/* Errata mask bits */
> +#define MACB_ERRATA_RXLOCKUP			0x00000001
> +
>  /* LSO settings */
>  #define MACB_LSO_UFO_ENABLE			0x01
>  #define MACB_LSO_TSO_ENABLE			0x02
> @@ -1085,6 +1088,7 @@ struct macb_config {
>  			    struct clk **rx_clk);
>  	int	(*init)(struct platform_device *pdev);
>  	int	jumbo_max_len;
> +	u32	errata;
>  };
>  
>  struct tsu_incr {
> @@ -1214,6 +1218,8 @@ struct macb {
>  
>  	int	rx_bd_rd_prefetch;
>  	int	tx_bd_rd_prefetch;
> +
> +	u32 errata;
>  };

Hi Harini,

Could this be made into simpler by instead adding a caps bit, named
(perhaps) MACB_CAPS_BUGGY_RXUBR or MACB_CAPS_NEEDS_RXUBR_RESETS or
something?

That would save needing to add a new u32 field into the macb_config and
macb structs (both of which already have this caps field).