linux-kernel - Re: [PATCH] clk: nomadik: Change to use DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <154344317086.88331.8296424241716107824@swboyd.mtv.corp.google.com>
Date:   Wed, 28 Nov 2018 14:12:50 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Yangtao Li <tiny.windzz@...il.com>, linus.walleij@...aro.org,
        mturquette@...libre.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yangtao Li <tiny.windzz@...il.com>
Subject: Re: [PATCH] clk: nomadik: Change to use DEFINE_SHOW_ATTRIBUTE macro

Quoting Stephen Boyd (2018-11-28 14:08:32)
> Quoting Yangtao Li (2018-11-23 07:06:00)
> > Use macro to simplify the code.
> > 
> > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > ---
> 
> Applied to clk-next
> 

Except this doesn't compile. I fixed it, but please actually compile
your patches before sending next time.

diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
index e331634d34df..a95aa96f4a68 100644
--- a/drivers/clk/clk-nomadik.c
+++ b/drivers/clk/clk-nomadik.c
@@ -455,7 +455,7 @@ static const char * const src_clk_names[] = {
 	"RNGCCLK   ",
 };
 
-static int nomadik_src_clk_show(struct seq_file *s, void *what)
+static int nomadik_src_clk_debugfs_show(struct seq_file *s, void *what)
 {
 	int i;
 	u32 src_pcksr0 = readl(src_base + SRC_PCKSR0);