linux-kernel - Re: [PATCH] clk: nomadik: Change to use DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Nov 2018 13:56:29 +0800
From:   Frank Lee <tiny.windzz@...il.com>
To:     sboyd@...nel.org
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: nomadik: Change to use DEFINE_SHOW_ATTRIBUTE macro

On Thu, Nov 29, 2018 at 6:12 AM Stephen Boyd <sboyd@...nel.org> wrote:
>
> Quoting Stephen Boyd (2018-11-28 14:08:32)
> > Quoting Yangtao Li (2018-11-23 07:06:00)
> > > Use macro to simplify the code.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > > ---
> >
> > Applied to clk-next
> >
>
> Except this doesn't compile. I fixed it, but please actually compile
> your patches before sending next time.
Sorry, I will pay attention next time.

MBR,
Yangtao
>
> diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c
> index e331634d34df..a95aa96f4a68 100644
> --- a/drivers/clk/clk-nomadik.c
> +++ b/drivers/clk/clk-nomadik.c
> @@ -455,7 +455,7 @@ static const char * const src_clk_names[] = {
>         "RNGCCLK   ",
>  };
>
> -static int nomadik_src_clk_show(struct seq_file *s, void *what)
> +static int nomadik_src_clk_debugfs_show(struct seq_file *s, void *what)
>  {
>         int i;
>         u32 src_pcksr0 = readl(src_base + SRC_PCKSR0);