linux-kernel - RE: [PATCH 40/41] scsi: ufs: ufshcd: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Nov 2018 06:15:41 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Vinayak Holikatti <vinholikatti@...il.com>
CC:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tomas Winkler <tomas.winkler@...el.com>
Subject: RE: [PATCH 40/41] scsi: ufs: ufshcd: mark expected switch
 fall-throughs

Already submitted by Tomas:
https://www.spinics.net/lists/linux-scsi/msg125659.html

Thanks,
Avri

> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org <linux-scsi-owner@...r.kernel.org>
> On Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, November 28, 2018 6:34 AM
> To: Vinayak Holikatti <vinholikatti@...il.com>
> Cc: James E.J. Bottomley <jejb@...ux.ibm.com>; Martin K. Petersen
> <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org; Gustavo A. R. Silva <gustavo@...eddedor.com>
> Subject: [PATCH 40/41] scsi: ufs: ufshcd: mark expected switch fall-throughs
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1087954 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 003d489f1b4b..be207197b63f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1551,6 +1551,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
>  		 * currently running. Hence, fall through to cancel gating
>  		 * work and to enable clocks.
>  		 */
> +		/* fall through */
>  	case CLKS_OFF:
>  		ufshcd_scsi_block_requests(hba);
>  		hba->clk_gating.state = REQ_CLKS_ON;
> @@ -1562,6 +1563,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async)
>  		 * fall through to check if we should wait for this
>  		 * work to be done or not.
>  		 */
> +		/* fall through */
>  	case REQ_CLKS_ON:
>  		if (async) {
>  			rc = -EAGAIN;
> @@ -4620,6 +4622,7 @@ ufshcd_scsi_cmd_status(struct ufshcd_lrb *lrbp,
> int scsi_status)
>  	switch (scsi_status) {
>  	case SAM_STAT_CHECK_CONDITION:
>  		ufshcd_copy_sense_data(lrbp);
> +		/* fall through */
>  	case SAM_STAT_GOOD:
>  		result |= DID_OK << 16 |
>  			  COMMAND_COMPLETE << 8 |
> --
> 2.17.1