linux-kernel - Re: [PATCH v3] mtd: spi-nor: cast to u64 to avoid uint overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV6nm7yBFD4G5gCPTZMCpddGVMwNDPd9x6DaSCaqmzt9Q@mail.gmail.com>
Date:   Wed, 28 Nov 2018 09:41:07 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     huijin.park@...sung.com
Cc:     Boris Brezillon <boris.brezillon@...tlin.com>,
        Marek Vasut <marek.vasut@...il.com>,
        MTD Maling List <linux-mtd@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        bbanghj.park@...il.com
Subject: Re: [PATCH v3] mtd: spi-nor: cast to u64 to avoid uint overflows

On Wed, Nov 28, 2018 at 9:03 AM Huijin Park <huijin.park@...sung.com> wrote:
> From: "huijin.park" <huijin.park@...sung.com>
>
> The "params->size" is defined as "u64".
> And "info->sector_size" and "info->n_sectors" are defined as
> unsigned int and u16.
> Thus, u64 data might have strange data(loss data) if the result
> overflows an unsigned int.
> This patch casts "info->sector_size" to an u64.
>
> Signed-off-by: huijin.park <huijin.park@...sung.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds