linux-kernel - Re: [PATCH V2] ASoC: max98373: Added max98373

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181129112612.GB10570@sirena.org.uk>
Date:   Thu, 29 Nov 2018 11:26:12 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Grant Grundler <grundler@...omium.org>
Cc:     RyanS.Lee@...imintegrated.com, Liam Girdwood <lgirdwood@...il.com>,
        perex@...ex.cz, tiwai@...e.com,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Benson Leung <bleung@...omium.org>,
        alsa-devel@...a-project.org, LKML <linux-kernel@...r.kernel.org>,
        ryan.lee.maxim@...il.com
Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp
 reset

On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote:
> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee <RyanS.Lee@...imintegrated.com> wrote:

> > >Not seeing a changelog here like I asked for :(

> > Actually I added changelog as below. Do you mean this is not sufficient?

> The text is probably sufficient but not in a format that Mark can
> directly apply.
> Please take a quick look at Documentation/process/submitting-patches.rst.

> Mark wants the "commit message" to be before the '---' line. So move
> the "Changes:" text up to become the commit message and drop the
> "Changes" line. That should explain why this commit is needed and
> include the S-o-B line.

Right.  If you compare what's in git and what you're sending with other
commits and mails and make sure everything looks similar you're probably
on the right track.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)