linux-kernel - Re: [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <865b607c-8419-9c9e-0a00-018e87adf8de@baylibre.com>
Date:   Thu, 29 Nov 2018 12:26:45 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jian Hu <jian.hu@...ogic.com>, Jerome Brunet <jbrunet@...libre.com>
Cc:     Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>, Rob Herring <robh@...nel.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Mark Rutland <mark.rutland@....com>,
        Jianxin Pan <jianxin.pan@...ogic.com>,
        Hanjie Lin <hanjie.lin@...ogic.com>,
        linux-amlogic@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] i2c: meson: add support for Meson G12A SoC I2C
 controller

On 29/11/2018 11:59, Jian Hu wrote:
> Add compatible and data for G12A I2C controller.
> 
> Signed-off-by: Jian Hu <jian.hu@...ogic.com>
> ---
>  drivers/i2c/busses/i2c-meson.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-meson.c b/drivers/i2c/busses/i2c-meson.c
> index 90f5d04..b86eed7 100644
> --- a/drivers/i2c/busses/i2c-meson.c
> +++ b/drivers/i2c/busses/i2c-meson.c
> @@ -462,10 +462,15 @@ static int meson_i2c_remove(struct platform_device *pdev)
>  	.div_factor = 3,
>  };
>  
> +static const struct meson_i2c_data i2c_g12a_data = {
> +	.div_factor = 3,

Especially if the div_factor is the same as AXG.

If you have some other fixes for G12a in the pipe, you will add the new compatible and meson_i2c_data later,
for the div_factor, simply use the axg struct and compatible.

Neil

> +};
> +
>  static const struct of_device_id meson_i2c_match[] = {
>  	{ .compatible = "amlogic,meson6-i2c", .data = &i2c_meson6_data },
>  	{ .compatible = "amlogic,meson-gxbb-i2c", .data = &i2c_gxbb_data },
>  	{ .compatible = "amlogic,meson-axg-i2c", .data = &i2c_axg_data },
> +	{ .compatible = "amlogic,meson-g12a-i2c", .data = &i2c_g12a_data },
>  	{},
>  };
>  
>