linux-kernel - Re: [PATCH 03/11] mfd: db8500-prcmu: drop unused MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdafCor2dMB2JmCyWMnCsrXoP2X8rT4ABdPGnB5ad3OfJQ@mail.gmail.com>
Date:   Fri, 30 Nov 2018 23:19:42 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/11] mfd: db8500-prcmu: drop unused MODULE_ tags from
 non-modular code

On Thu, Nov 22, 2018 at 5:35 AM Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/mfd/Kconfig:config MFD_DB8500_PRCMU
> drivers/mfd/Kconfig:    bool "ST-Ericsson DB8500 Power Reset Control Management Unit"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We replace module.h with init.h and export.h ; the latter since the
> file does export some symbols.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Mattias Nilsson <mattias.i.nilsson@...ricsson.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij