linux-kernel - Re: [PATCH 00/12 v6] fs/locks: avoid thundering-herd wake-ups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c1dee36eee07975ef4c07802a8bd0c8076878ef.camel@kernel.org>
Date:   Fri, 30 Nov 2018 11:34:54 -0500
From:   Jeff Layton <jlayton@...nel.org>
To:     NeilBrown <neilb@...e.com>
Cc:     "J. Bruce Fields" <bfields@...ldses.org>,
        Martin Wilck <mwilck@...e.de>, linux-fsdevel@...r.kernel.org,
        Frank Filz <ffilzlnx@...dspring.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/12 v6] fs/locks: avoid thundering-herd wake-ups

On Fri, 2018-11-30 at 10:04 +1100, NeilBrown wrote:
> This series has the fixes for the recently reported performance
> regressions merged into the patches which caused them.
> It also has a couple of little fixes that have been mentioned on the
> list, and that Jeff had merged into his copy.
> 
> Thanks,
> NeilBrown
> 
> ---
> 
> NeilBrown (12):
>       fs/locks: rename some lists and pointers.
>       fs/locks: split out __locks_wake_up_blocks().
>       NFS: use locks_copy_lock() to copy locks.
>       gfs2: properly initial file_lock used for unlock.
>       ocfs2: properly initial file_lock used for unlock.
>       fs/locks: use properly initialized file_lock when unlocking.
>       fs/locks: allow a lock request to block other requests.
>       fs/locks: always delete_block after waiting.
>       fs/locks: change all *_conflict() functions to return bool.
>       fs/locks: create a tree of dependent requests.
>       fs/locks: merge posix_unblock_lock() and locks_delete_block()
>       fs/locks: locks: remove unnecessary white space.
> 
> 
>  fs/cifs/file.c                  |    4 
>  fs/gfs2/file.c                  |   10 +
>  fs/lockd/svclock.c              |    2 
>  fs/locks.c                      |  342 +++++++++++++++++++++++++--------------
>  fs/nfs/nfs4proc.c               |    6 -
>  fs/nfsd/nfs4state.c             |    6 -
>  fs/ocfs2/locks.c                |   10 +
>  include/linux/fs.h              |   13 +
>  include/trace/events/filelock.h |   16 +-
>  9 files changed, 252 insertions(+), 157 deletions(-)
> 
> --
> Signature
> 

Thanks Neil,

This looks great. I've gone ahead and replaced the set in locks-next
with this one. Unless we hear of any other problems, I'll plan to send a
PR to Linus when the merge window opens.

Cheers,
-- 
Jeff Layton <jlayton@...nel.org>