linux-kernel - Re: [PATCH] Malformatted switch statment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181202.220412.1682693749796493451.davem@davemloft.net>
Date:   Sun, 02 Dec 2018 22:04:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     joris.gutjahr@...il.com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Malformatted switch statment

From: Joris Gutjahr <joris.gutjahr@...il.com>
Date: Sun, 28 Oct 2018 17:45:46 +0100

> I fixed this coding style error I got after running
> checkpatch --file on this file.
> The problem was that the whole case block was on one line.
> 
> Signed-off-by: Joris Gutjahr <joris.gutjahr@...il.com>

Frankly I think the existing code is more compact and easier
to read and understand.

Checkpatch is a tool, and it's results need be interpreated
and evaluated by human beings.  It's not to be taken as the
final verdict.

I'm not applying this, sorry.