linux-kernel - Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181204144145.116a2caf@vmware.local.home>
Date:   Tue, 4 Dec 2018 14:41:45 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tzvetomir Stoyanov <tstoyanov@...are.com>, kernel-team@....com
Subject: Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API
 header file

On Tue, 4 Dec 2018 16:47:39 +0900
Namhyung Kim <namhyung@...nel.org> wrote:


> > @@ -302,6 +302,7 @@ install_headers:
> >  	$(call QUIET_INSTALL, headers) \
> >  		$(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \
> >  		$(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \
> > +		$(call do_install,trace-seq.h,$(prefix)/include/traceevent,644); \
> >  		$(call do_install,kbuffer.h,$(prefix)/include/traceevent,644)  
> 
> Do you still wanna have 'traceevent' directory prefix?  I just
> sometimes feel a bit annoying to type it. ;-)

I'd still want the separate directory for it. I'll probably have a
ftrace.h file added to this for ftrace specific code in the future.

> 
> Or you can rename it something like 'tep' or 'libtep' - and hopefully
> having only single header file to include..
>

Hmm, I wonder if we should just call the directory "trace"?

-- Steve