linux-kernel - Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205122517.GG2950@krava>
Date:   Wed, 5 Dec 2018 13:25:17 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Namhyung Kim <namhyung@...nel.org>, linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Tzvetomir Stoyanov <tstoyanov@...are.com>, kernel-team@....com
Subject: Re: [PATCH 3/9] tools/lib/traceevent: Install trace-seq.h API header
 file

On Tue, Dec 04, 2018 at 02:41:45PM -0500, Steven Rostedt wrote:
> On Tue, 4 Dec 2018 16:47:39 +0900
> Namhyung Kim <namhyung@...nel.org> wrote:
> 
> 
> > > @@ -302,6 +302,7 @@ install_headers:
> > >  	$(call QUIET_INSTALL, headers) \
> > >  		$(call do_install,event-parse.h,$(prefix)/include/traceevent,644); \
> > >  		$(call do_install,event-utils.h,$(prefix)/include/traceevent,644); \
> > > +		$(call do_install,trace-seq.h,$(prefix)/include/traceevent,644); \
> > >  		$(call do_install,kbuffer.h,$(prefix)/include/traceevent,644)  
> > 
> > Do you still wanna have 'traceevent' directory prefix?  I just
> > sometimes feel a bit annoying to type it. ;-)
> 
> I'd still want the separate directory for it. I'll probably have a
> ftrace.h file added to this for ftrace specific code in the future.
> 
> > 
> > Or you can rename it something like 'tep' or 'libtep' - and hopefully
> > having only single header file to include..
> >
> 
> Hmm, I wonder if we should just call the directory "trace"?

hum, I think it should match the library name, like 'include/tep/'

also we should change the plugin installation directory

[jolsa@...va traceevent]$ rpm -ql perf | grep traceevent
/usr/lib64/traceevent
/usr/lib64/traceevent/plugins
/usr/lib64/traceevent/plugins/plugin_cfg80211.so
/usr/lib64/traceevent/plugins/plugin_function.so
/usr/lib64/traceevent/plugins/plugin_hrtimer.so
/usr/lib64/traceevent/plugins/plugin_jbd2.so
/usr/lib64/traceevent/plugins/plugin_kmem.so
/usr/lib64/traceevent/plugins/plugin_kvm.so
/usr/lib64/traceevent/plugins/plugin_mac80211.so
/usr/lib64/traceevent/plugins/plugin_sched_switch.so
/usr/lib64/traceevent/plugins/plugin_scsi.so
/usr/lib64/traceevent/plugins/plugin_xen.so

jirka