linux-kernel - Re: [PATCH 4/6] power: supply: charger-manager: Make code more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205203659.zq2fprcfwb6mpgfg@earth.universe>
Date:   Wed, 5 Dec 2018 21:36:59 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        yuanjiang.yu@...soc.com, broonie@...nel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCH 4/6] power: supply: charger-manager: Make code more
 readable

Hi,

On Fri, Nov 16, 2018 at 07:01:11PM +0800, Baolin Wang wrote:
> Make code more readable.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index a52bc77..dc0c9a6 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -1520,19 +1520,19 @@ static struct charger_desc *of_cm_parse_desc(struct device *dev)
>  	/* chargers */
>  	of_property_read_u32(np, "cm-num-chargers", &num_chgs);
>  	if (num_chgs) {
> +		int i;
> +
>  		/* Allocate empty bin at the tail of array */
>  		desc->psy_charger_stat = devm_kcalloc(dev,
>  						      num_chgs + 1,
>  						      sizeof(char *),
>  						      GFP_KERNEL);
> -		if (desc->psy_charger_stat) {
> -			int i;
> -			for (i = 0; i < num_chgs; i++)
> -				of_property_read_string_index(np, "cm-chargers",
> -						i, &desc->psy_charger_stat[i]);
> -		} else {
> +		if (!desc->psy_charger_stat)
>  			return ERR_PTR(-ENOMEM);
> -		}
> +
> +		for (i = 0; i < num_chgs; i++)
> +			of_property_read_string_index(np, "cm-chargers",
> +						      i, &desc->psy_charger_stat[i]);
>  	}
>  
>  	of_property_read_string(np, "cm-fuel-gauge", &desc->psy_fuel_gauge);
> -- 
> 1.7.9.5
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)