linux-kernel - Re: [PATCH 3/6] power: supply: charger-manager: Fix incorrect return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181205203634.f6u2yo7v3gonv2cm@earth.universe>
Date:   Wed, 5 Dec 2018 21:36:34 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Baolin Wang <baolin.wang@...aro.org>
Cc:     robh+dt@...nel.org, mark.rutland@....com, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        yuanjiang.yu@...soc.com, broonie@...nel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCH 3/6] power: supply: charger-manager: Fix incorrect return
 value

Hi,

On Fri, Nov 16, 2018 at 07:01:10PM +0800, Baolin Wang wrote:
> Fix incorrect return value.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index bd6c450..a52bc77 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -1212,7 +1212,6 @@ static int charger_extcon_init(struct charger_manager *cm,
>  	if (ret < 0) {
>  		pr_info("Cannot register extcon_dev for %s(cable: %s)\n",
>  			cable->extcon_name, cable->name);
> -		ret = -EINVAL;
>  	}
>  
>  	return ret;
> @@ -1633,7 +1632,7 @@ static int charger_manager_probe(struct platform_device *pdev)
>  
>  	if (IS_ERR(desc)) {
>  		dev_err(&pdev->dev, "No platform data (desc) found\n");
> -		return -ENODEV;
> +		return PTR_ERR(desc);
>  	}
>  
>  	cm = devm_kzalloc(&pdev->dev, sizeof(*cm), GFP_KERNEL);
> -- 
> 1.7.9.5
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)