linux-kernel - Re: linux-next: build failure after merge of the rdma tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181206095815.6e814057@canb.auug.org.au>
Date:   Thu, 6 Dec 2018 09:58:15 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     "Guy Levi(SW)" <guyle@...lanox.com>
Cc:     Jason Gunthorpe <jgg@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Majd Dibbiny <majd@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Changbin Du <changbin.du@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: linux-next: build failure after merge of the rdma tree

Hi Guy,

On Wed, 5 Dec 2018 12:25:57 +0000 "Guy Levi(SW)" <guyle@...lanox.com> wrote:
>
> > 
> > Huh. So apparently every compiler that tested this patch (0-day, mine,
> > the submitters) optimized this call away because is_atomic_response()
> > always returns 0: meaning mlx5_get_atomic_laddr is never callable and
> > can be deleted entirely, including the call to mlx5_get_send_wqe.
> > 
> > Not sure what compiler setup will hit this, but it is clearly wrong
> > code..  
> 
> Flag -o0  ?

No, but the kbuild tree contains a change that allows turning off of
gcc's autoinlining and the CONFIG option guarding that gets turned on
for allmodconfig builds among others.

Masahiro, should CONFIG_NO_AUTO_INLINE maybe need to be off unless
explicitly enabled (like CONFIG_DEBUG_INFO and others)?

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped