| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Dec 2018 15:41:22 +0530
From: Rajendra Nayak <rnayak@...eaurora.org>
To: Stephen Boyd <sboyd@...nel.org>, andy.gross@...aro.org,
collinsd@...eaurora.org, mka@...omium.org, robh@...nel.org,
ulf.hansson@...aro.org, viresh.kumar@...aro.org
Cc: devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/8] soc: qcom: rpmpd: Add support for get/set
performance state
On 12/5/2018 12:33 PM, Rajendra Nayak wrote:
>>
>>> + return 0;
>>> + }
>>> +
>>> + of_node_put(np);
>>
>> This same code exists twice. Perhaps a helper needs to exist for
>> qcom_rpm_get_performance() to pull the number out of the DT.
>
> Sure I can make both drivers use a common helper instead of duplicating it.
which would mean I will need to create a new file just to define the
common helper. Does that seem like an overkill?
Powered by blists - more mailing lists