linux-kernel - Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181207144045.GT3073@unbuntlaptop>
Date:   Fri, 7 Dec 2018 17:40:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Minas Harutyunyan <minas.harutyunyan@...opsys.com>
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>,
        Maynard CABIENTE <maynard.cabiente@...itan.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on
 disconnect"

On Fri, Dec 07, 2018 at 02:13:18PM +0000, Minas Harutyunyan wrote:
> 
> My patch doesn't pass sparse checking: "warning: context imbalance in 
> 'dwc2_hsotg_core_init_disconnected' - unexpected unlock". Sparse persist!
> So, I need to re-work patch. Can I use your idea with 
> dwc2_hsotg_ep_disable_lock() function to prepare new one?
> 

Sparse lock checking is pretty crap, and I wouldn't go out of my way
normally to make it happy...  But of course you can use my idea.

regards,
dan carpenter