linux-kernel - Re: [PATCH] x86/vdso: drop implicit common-page-size linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=g_eQwCdtO7bwCx4ykOjCBhw637X=TVc+hqatS+XbNjg@mail.gmail.com>
Date:   Fri, 7 Dec 2018 10:00:52 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     bp@...en8.de
Cc:     luto@...nel.org, Fangrui Song <maskray@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>, andi@...stfloor.org,
        Dmitry Golovin <dima@...ovin.in>,
        Bill Wendling <morbo@...gle.com>, Rui Ueyama <ruiu@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
        rafael@...indo.la, Stephen Hines <srhines@...gle.com>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] x86/vdso: drop implicit common-page-size linker flag

On Fri, Dec 7, 2018 at 9:53 AM Borislav Petkov <bp@...en8.de> wrote:
>
> On Fri, Dec 07, 2018 at 09:45:42AM -0800, Nick Desaulniers wrote:
> > Google's Native Client, a technology for running native code in a web
> > browser.  It's since been superseded by Portable Native Client (pNaCl)
> > and to an extent Web Assembly.  It seems that BFD still contains code
> > for NaCl.
>
> Yeah, found the wikipedia page. :)
>
> > How does this sound:
> > TL;DR
> > -z common-page-size's default value is based on the target
> > architecture.  arch/x86/entry/vdso/Makefile sets it to the
> > architecture default, which is implicit and redundant.  Drop it.
>
> Sure. Although the longer explanation gives more insight into the whole
> deal but that's fine too - the longer explanation is on the ML and we
> have the Link: tags.
>
> So no need to resend - I'll simply take the three-liner above.

Thanks, it's being set to the default value again for x86 usermode
linux, arm, and for sparc.  I'll send additional clean ups for those
three.
-- 
Thanks,
~Nick Desaulniers