linux-kernel - [tip:x86/urgent] x86/vdso: Drop implicit common-page-size linker flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-ac3e233d29f7f77f28243af0132057d378d3ea58@git.kernel.org>
Date:   Fri, 7 Dec 2018 10:33:56 -0800
From:   tip-bot for Nick Desaulniers <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     morbo@...gle.com, hpa@...or.com, dima@...ovin.in, luto@...nel.org,
        maskray@...gle.com, mingo@...hat.com, andi@...stfloor.org,
        ndesaulniers@...gle.com, ruiu@...gle.com, mingo@...nel.org,
        x86@...nel.org, tglx@...utronix.de, bp@...e.de,
        linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86/vdso: Drop implicit common-page-size linker
 flag

Commit-ID:  ac3e233d29f7f77f28243af0132057d378d3ea58
Gitweb:     https://git.kernel.org/tip/ac3e233d29f7f77f28243af0132057d378d3ea58
Author:     Nick Desaulniers <ndesaulniers@...gle.com>
AuthorDate: Thu, 6 Dec 2018 11:12:31 -0800
Committer:  Borislav Petkov <bp@...e.de>
CommitDate: Fri, 7 Dec 2018 18:57:38 +0100

x86/vdso: Drop implicit common-page-size linker flag

GNU linker's -z common-page-size's default value is based on the target
architecture. arch/x86/entry/vdso/Makefile sets it to the architecture
default, which is implicit and redundant. Drop it.

Fixes: 2aae950b21e4 ("x86_64: Add vDSO for x86-64 with gettimeofday/clock_gettime/getcpu")
Reported-by: Dmitry Golovin <dima@...ovin.in>
Reported-by: Bill Wendling <morbo@...gle.com>
Suggested-by: Dmitry Golovin <dima@...ovin.in>
Suggested-by: Rui Ueyama <ruiu@...gle.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>
Signed-off-by: Borislav Petkov <bp@...e.de>
Acked-by: Andy Lutomirski <luto@...nel.org>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Fangrui Song <maskray@...gle.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: Ingo Molnar <mingo@...hat.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: x86-ml <x86@...nel.org>
Link: https://lkml.kernel.org/r/20181206191231.192355-1-ndesaulniers@google.com
Link: https://bugs.llvm.org/show_bug.cgi?id=38774
Link: https://github.com/ClangBuiltLinux/linux/issues/31
---
 arch/x86/entry/vdso/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 141d415a8c80..0624bf2266fd 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -47,7 +47,7 @@ targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so)
 CPPFLAGS_vdso.lds += -P -C
 
 VDSO_LDFLAGS_vdso.lds = -m elf_x86_64 -soname linux-vdso.so.1 --no-undefined \
-			-z max-page-size=4096 -z common-page-size=4096
+			-z max-page-size=4096
 
 $(obj)/vdso64.so.dbg: $(obj)/vdso.lds $(vobjs) FORCE
 	$(call if_changed,vdso)
@@ -98,7 +98,7 @@ CFLAGS_REMOVE_vvar.o = -pg
 
 CPPFLAGS_vdsox32.lds = $(CPPFLAGS_vdso.lds)
 VDSO_LDFLAGS_vdsox32.lds = -m elf32_x86_64 -soname linux-vdso.so.1 \
-			   -z max-page-size=4096 -z common-page-size=4096
+			   -z max-page-size=4096
 
 # x32-rebranded versions
 vobjx32s-y := $(vobjs-y:.o=-x32.o)