linux-kernel - Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181207181648.GQ23156@windriver.com>
Date:   Fri, 7 Dec 2018 13:16:49 -0500
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     Charles Keepax <ckeepax@...nsource.cirrus.com>
CC:     Lee Jones <lee.jones@...aro.org>, <linux-kernel@...r.kernel.org>,
        <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular

[Re: [PATCH 18/22] mfd: wm831x-i2c: Make it explicitly non-modular] On 05/12/2018 (Wed 11:38) Charles Keepax wrote:

> On Sun, Dec 02, 2018 at 11:23:25PM -0500, Paul Gortmaker wrote:

[...]

> > -static int wm831x_i2c_remove(struct i2c_client *i2c)
> > -{
> > -	struct wm831x *wm831x = i2c_get_clientdata(i2c);
> > -
> > -	wm831x_device_exit(wm831x);
> 
> These patches remove the only callers of wm831x_device_exit, so I
> guess we should probably remove that function too?

Agreed. I've ammended the 831x-core patch to remove this as well.
Thanks for spotting it.  Will send v3 shortly.

Paul.
--

> 
> Thanks,
> Charles