linux-kernel - Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Dec 2018 12:46:30 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     sean.j.christopherson@...el.com
Cc:     dave.hansen@...ux.intel.com, Andrew Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, bp@...en8.de,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Peter Anvin <hpa@...or.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Rik van Riel <riel@...riel.com>, yu-cheng.yu@...el.com,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2] x86/fault: Decode and print #PF oops in human readable form

On Fri, Dec 7, 2018 at 11:52 AM Sean Christopherson
<sean.j.christopherson@...el.com> wrote:
>
> Remove the per-bit decoding of the error code and instead print:

The patch looks fine to me, so feel free to add an acked-by, but:

 (a) I'm not the one who wanted the human-legible version in the first
place, since I'm also perfectly ok with just the error code, so my
judgement is obviously garbage wrt this whole thing

 (b) it would be good to have a couple of actual examples of the
printout to judge.

I can certainly imagine how it looks just from the patch, but maybe if
I actually see reality I'd go "eww". Or somebody else goes "eww".

              Linus

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5120 bytes)