linux-kernel - Re: [PATCH] checkstack.pl: fix for aarch64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1544215614.18411.1.camel@lca.pw>
Date:   Fri, 07 Dec 2018 15:46:54 -0500
From:   Qian Cai <cai@....pw>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkstack.pl: fix for aarch64

On Fri, 2018-12-07 at 12:24 -0800, Andrew Morton wrote:
> On Fri,  7 Dec 2018 14:58:43 -0500 Qian Cai <cai@....pw> wrote:
> 
> > There is actually a space after "sp," like this,
> > 
> > ffff2000080813c8:       a9bb7bfd        stp     x29, x30, [sp, #-80]!
> > 
> 
> Confused.  Why does this matter?  Why is the patched version superior?

<Resend in plain text.>

Right now, checkstack.pl won’t be able to  print anything on aarch64, because it
won’t be able to match the stating objdump line of a function due to this
missing space. Hence, it saw every stack is zero-size.

After applied this patch, checkpatch.pl is able to match the start of a
function’s objdump, and then be able to calculate each function’s stack
correctly.