linux-kernel - Re: [PATCH] mm/mmu_notifier: fix mmu_notifier_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1812111424400.124369@chino.kir.corp.google.com>
Date:   Tue, 11 Dec 2018 14:25:02 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Arnd Bergmann <arnd@...db.de>
cc:     Jérôme Glisse <jglisse@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Michal Hocko <mhocko@...e.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/mmu_notifier: fix mmu_notifier_range_init warning

On Tue, 11 Dec 2018, Arnd Bergmann wrote:

> > Hmm, strange that Arnd's build failure is only reporting about an unused
> > variable instead of MMU_NOTIFY_CLEAR being undefined :/
> >
> > I think this should be done so that anybody using
> > mmu_notifier_range_init() doesn't need to worry about the implications of
> > *any* unused formal parameter as a result of how the #define is formed:
> 
> Your patch below is more or less what I tried at first, and that resulted
> in another build failure for
> 
> mm/hugetlb.c:   mmu_notifier_range_init(&range, mm, start, end,
> MMU_NOTIFY_CLEAR);
> mm/hugetlb.c-   adjust_range_if_pmd_sharing_possible(vma,
> &range.start, &range.end);
> 
> where range.end refers to a nonexisting member of range.
> 

Isn't that separate?  It seems like there is a strict dependency that 
CONFIG_HUGETLBFS has on CONFIG_MMU_NOTIFIER.