linux-kernel - Re: [PATCH] nvme-rdma: complete requests from ->timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c645f196-3fbb-c9b9-5686-730ceed102fa@grimberg.me>
Date:   Tue, 11 Dec 2018 15:38:57 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Jaesoo Lee <jalee@...estorage.com>, nitzanc@...lanox.com
Cc:     keith.busch@...el.com, axboe@...com, hch@....de,
        Roland Dreier <roland@...estorage.com>,
        Prabhath Sajeepa <psajeepa@...estorage.com>,
        Ashish Karkare <ashishk@...estorage.com>,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH] nvme-rdma: complete requests from ->timeout

> I cannot reproduce the bug with the patch; in my failure scenarios, it
> seems that completing the request on errors in nvme_rdma_send_done
> makes __nvme_submit_sync_cmd to be unblocked. Also, I think this is
> safe from the double completions.
> 
> However, it seems that nvme_rdma_timeout code is still not free from
> the double completion problem. So, it looks promising to me if you
> could separate out the nvme_rdma_wr_error handling code as a new
> patch.

Guys, can you please send proper patches so we can review properly?