linux-kernel - Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181211000049.GA19806@hori1.linux.bs1.fc.nec.co.jp>
Date:   Tue, 11 Dec 2018 00:00:49 +0000
From:   Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:     Anthony Yznaga <anthony.yznaga@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "chansen3@...co.com" <chansen3@...co.com>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "willy@...radead.org" <willy@...radead.org>,
        "rientjes@...gle.com" <rientjes@...gle.com>
Subject: Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer
 pages than expected" failures

On Tue, Dec 04, 2018 at 02:24:29PM -0800, Anthony Yznaga wrote:
> Because kpagecount_read() fakes success if map counts are not being
> collected, clamp the page count passed to it by walk_pfn() to the pages
> value returned by the preceding call to kpageflags_read().
> 
> Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
> Signed-off-by: Anthony Yznaga <anthony.yznaga@...cle.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

> ---
>  tools/vm/page-types.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
> index 37908a83ddc2..1ff3a6c0367b 100644
> --- a/tools/vm/page-types.c
> +++ b/tools/vm/page-types.c
> @@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
>  		if (kpagecgroup_read(cgi, index, pages) != pages)
>  			fatal("kpagecgroup returned fewer pages than expected");
>  
> -		if (kpagecount_read(cnt, index, batch) != pages)
> +		if (kpagecount_read(cnt, index, pages) != pages)
>  			fatal("kpagecount returned fewer pages than expected");
>  
>  		for (i = 0; i < pages; i++)
> -- 
> 1.8.3.1
> 
>