linux-kernel - Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1544487006.3301683.1605247720.567E9685@webmail.messagingengine.com>
Date:   Tue, 11 Dec 2018 10:40:06 +1030
From:   Andrew Jeffery <andrew@...id.au>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     Joel Stanley <joel@....id.au>, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option



On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> Clang does not support this option:
> 
> warning: unknown warning option '-Woverride-init'; did you mean
> '-Woverride-module'? [-Wunknown-warning-option]
> 1 warning generated.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Acked-by: Andrew Jeffery <andrew@...id.au>

> ---
>  drivers/pinctrl/aspeed/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/aspeed/Makefile b/drivers/pinctrl/aspeed/Makefile
> index 191ed0fc1804..790b406aae19 100644
> --- a/drivers/pinctrl/aspeed/Makefile
> +++ b/drivers/pinctrl/aspeed/Makefile
> @@ -1,6 +1,6 @@
>  # Aspeed pinctrl support
>  
> -ccflags-y += -Woverride-init
> +ccflags-y += $(call cc-option,-Woverride-init)
>  obj-$(CONFIG_PINCTRL_ASPEED)	+= pinctrl-aspeed.o
>  obj-$(CONFIG_PINCTRL_ASPEED_G4)	+= pinctrl-aspeed-g4.o
>  obj-$(CONFIG_PINCTRL_ASPEED_G5)	+= pinctrl-aspeed-g5.o
> -- 
> 2.20.0
>