linux-kernel - Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 09:18:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Anson Huang <anson.huang@....com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Mark Rutland <mark.rutland@....com>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
 supply name

On Mon, Dec 10, 2018 at 7:40 PM Anson Huang <anson.huang@....com> wrote:
>
> Hi, Rob
>
> Best Regards!
> Anson Huang
>
> > -----Original Message-----
> > From: Rob Herring [mailto:robh@...nel.org]
> > Sent: 2018年12月11日 7:24
> > To: Anson Huang <anson.huang@....com>
> > Cc: jic23@...nel.org; knaack.h@....de; lars@...afoo.de;
> > pmeerw@...erw.net; mark.rutland@....com; linux-iio@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> > <linux-imx@....com>
> > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
> > supply name
> >
> > On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote:
> > > According to datasheet, the isl29018 has "vddd/vdda" power supply, and
> > > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply
> > > name with "vdd" and "vdda" according to datasheet to cover all devices
> > > and avoid confusion.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > index b9bbde3..36f737d 100644
> > > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > > @@ -15,7 +15,9 @@ Optional properties:
> > >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> > >    node bindings.
> > >
> > > -  - vcc-supply: phandle to the regulator that provides power to the sensor.
> > > +  - vdd-supply: phandle to the regulator that provides vdd power to the
> > sensor.
> > > +
> > > +  - vdda-supply: phandle to the regulator that provides vdda power to the
> > sensor.
> >
> > Is this in use? You can't just change things if it is.
>
> I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all,
> so I take this chance to update it according to datasheet. Thanks.

arch/arm/boot/dts/exynos5420-peach-pit.dts-629- light-sensor@44 {
arch/arm/boot/dts/exynos5420-peach-pit.dts:630:         compatible =
"isil,isl29018";
arch/arm/boot/dts/exynos5420-peach-pit.dts-631-         reg = <0x44>;
arch/arm/boot/dts/exynos5420-peach-pit.dts-632-         vcc-supply =
<&tps65090_fet5>;
arch/arm/boot/dts/exynos5420-peach-pit.dts-633- };

arch/arm/boot/dts/exynos5800-peach-pi.dts-629-  light-sensor@44 {
arch/arm/boot/dts/exynos5800-peach-pi.dts:630:          compatible =
"isil,isl29018";
arch/arm/boot/dts/exynos5800-peach-pi.dts-631-          reg = <0x44>;
arch/arm/boot/dts/exynos5800-peach-pi.dts-632-          vcc-supply =
<&tps65090_fet5>;
arch/arm/boot/dts/exynos5800-peach-pi.dts-633-  };

The rest of the dts files using this don't have a supply it seems. So
you need permission from the Exynos folks if you want to just drop
this. And also update their dts files.

Rob