linux-kernel - RE: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB3916E1651ABC07F6F788B265F5A60@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 11 Dec 2018 01:38:53 +0000
From:   Anson Huang <anson.huang@....com>
To:     Rob Herring <robh@...nel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>,
        "knaack.h@....de" <knaack.h@....de>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
 supply name

Hi, Rob

Best Regards!
Anson Huang

> -----Original Message-----
> From: Rob Herring [mailto:robh@...nel.org]
> Sent: 2018年12月11日 7:24
> To: Anson Huang <anson.huang@....com>
> Cc: jic23@...nel.org; knaack.h@....de; lars@...afoo.de;
> pmeerw@...erw.net; mark.rutland@....com; linux-iio@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
> supply name
> 
> On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote:
> > According to datasheet, the isl29018 has "vddd/vdda" power supply, and
> > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply
> > name with "vdd" and "vdda" according to datasheet to cover all devices
> > and avoid confusion.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > ---
> >  Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > index b9bbde3..36f737d 100644
> > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt
> > @@ -15,7 +15,9 @@ Optional properties:
> >    Refer to interrupt-controller/interrupts.txt for generic interrupt client
> >    node bindings.
> >
> > -  - vcc-supply: phandle to the regulator that provides power to the sensor.
> > +  - vdd-supply: phandle to the regulator that provides vdd power to the
> sensor.
> > +
> > +  - vdda-supply: phandle to the regulator that provides vdda power to the
> sensor.
> 
> Is this in use? You can't just change things if it is.

I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all,
so I take this chance to update it according to datasheet. Thanks.

Anson


> 
> Rob