linux-kernel - Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Dec 2018 22:29:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     amhetre@...dia.com
Cc:     herbert@...dor.apana.org.au, axboe@...nel.dk,
        adrian.hunter@...el.com, ulf.hansson@...aro.org,
        linux-crypto@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, vdumpa@...dia.com,
        mmaddireddy@...dia.com, Snikam@...dia.com,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] scatterlist: Update size type to support greater then
 4GB size.

From: Ashish Mhetre <amhetre@...dia.com>
Date: Wed, 12 Dec 2018 11:54:13 +0530

> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 68e91ef..0a07a29 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -587,7 +587,7 @@ enum {
>  
>  struct nvme_sgl_desc {
>  	__le64	addr;
> -	__le32	length;
> +	__le64	length;
>  	__u8	rsvd[3];
>  	__u8	type;
>  };

Isn't this a device or protocol defined datastructure?  You can't just
change it like this.