linux-kernel - Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power supply name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Dec 2018 10:51:39 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     Yongcai Huang <anson.huang@....com>
Cc:     Rob Herring <robh@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Mark Rutland <mark.rutland@....com>, linux-iio@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power
 supply name

Hi Anson,

On Wed, Dec 12, 2018 at 10:49 AM Anson Huang <anson.huang@....com> wrote:

>         Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name “VDD” in datasheet for regulator name?

Ok, understood. In this case, I would suggest keeping the existing name.