linux-kernel - Re: [PATCH] arch: arm: socfpga: arria10: Add stmmac ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c703c4d4-4442-19b1-8645-aa906b08f7e6@kernel.org>
Date:   Thu, 13 Dec 2018 15:56:50 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     dwesterg@...il.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        thor.thayer@...el.com
Cc:     Dalon Westergreen <dalon.westergreen@...ux.intel.com>
Subject: Re: [PATCH] arch: arm: socfpga: arria10: Add stmmac ptp_ref clock to
 socdk devicetree



On 12/13/18 2:59 PM, dwesterg@...il.com wrote:
> From: Dalon Westergreen <dalon.westergreen@...ux.intel.com>
> 
> Add the stmmac ptp_ref clock as it is configured in the arria10 socdk.
> The stmmac driver defaults the ptp_ref clock to the main stmmac clock
> if the ptp_ref clock is not set in the devicetree.  This is inapprotiate

s/inapprotiate/inappropriate

> for the arria10 socdk.
> 
> Signed-off-by: Dalon Westergreen <dalon.westergreen@...ux.intel.com>
> ---
>  arch/arm/boot/dts/socfpga_arria10_socdk.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> index 2a7466891d0e..58bfa84dcdb3 100644
> --- a/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> +++ b/arch/arm/boot/dts/socfpga_arria10_socdk.dtsi
> @@ -74,7 +74,8 @@
>  &gmac0 {
>  	phy-mode = "rgmii";
>  	phy-addr = <0xffffffff>; /* probe for phy addr */
> -
> +	clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
> +	clock-names = "stmmaceth", "ptp_ref";
>  	
These should go into the base arria10 dtsi at socfpga_arria10.dtsi?
Should the other gmacs get the same updates?

Also the patch header should be "ARM: dts: arria10:"

Dinh