linux-kernel - Re: [PATCH] dt-bindings: i2c: sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c987f09c-689f-7e89-d496-f53b0ab6c2c1@axentia.se>
Date:   Thu, 13 Dec 2018 21:57:59 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Fabrizio Castro <fabrizio.castro@...renesas.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
CC:     Simon Horman <horms+renesas@...ge.net.au>,
        Wolfram Sang <wsa@...-dreams.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Biju Das <biju.das@...renesas.com>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Simon Horman <horms@...ge.net.au>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: i2c: sh_mobile: Add r8a774c0 support

On 2018-12-13 21:19, Fabrizio Castro wrote:
> Document RZ/G2E (R8A774C0) SoC bindings.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> index bc876b7..3dff89f 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> @@ -8,6 +8,7 @@ Required properties:
>  			- "renesas,iic-r8a7744" (RZ/G1N)
>  			- "renesas,iic-r8a7745" (RZ/G1E)
>  			- "renesas,iic-r8a774a1" (RZ/G2M)
> +			- "renesas,iic-r8a774c0" (RZ/G2E)
>  			- "renesas,iic-r8a7790" (R-Car H2)
>  			- "renesas,iic-r8a7791" (R-Car M2-W)
>  			- "renesas,iic-r8a7792" (R-Car V2H)
> @@ -32,7 +33,7 @@ Required properties:
>  			When compatible with "renesas,rmobile-iic" it should
>  			be the last compatibility string listed.
>  
> -			The r8a77990 (R-Car E3) controller is not
> +			The r8a77990 (R-Car E3) and RZ/G2E controllers are not

The references to these two controllers do not follow the same style.
I'd either delete r8a77990 and get "R-Car E3 and RZ/G2E" or add
r8a774c0 in front of RZ/G2E (bracketed), with a slight preference
for the latter.

Cheers,
Peter

>  			considered compatible with "renesas,rcar-gen3-iic"
>  			or "renesas,rmobile-iic" due to the absence of
>  			automatic transmission registers.
>