linux-kernel - RE: [PATCH -next] usb: renesas_usbhs: Fix unused function warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OSAPR01MB2290C7C3221C7BE4594DB31CD8A00@OSAPR01MB2290.jpnprd01.prod.outlook.com>
Date:   Thu, 13 Dec 2018 03:41:35 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "horms+renesas@...ge.net.au" <horms+renesas@...ge.net.au>,
        "fengguang.wu@...el.com" <fengguang.wu@...el.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH -next] usb: renesas_usbhs: Fix unused function warning
 when CONFIG_PM not set

Hi,

> From: YueHaibing, Sent: Thursday, December 13, 2018 12:19 PM
> 
> with CONFIG_PM not set, gcc warning this:
> drivers/usb/renesas_usbhs/common.c:844:12:
>  warning: 'usbhsc_suspend' defined but not used [-Wunused-function]
> drivers/usb/renesas_usbhs/common.c:860:12:
>  warning: 'usbhsc_resume' defined but not used [-Wunused-function]
> 
> fix this by adding #ifdef around it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thank you for the patch.
However, this issue is already fixed on the Greg's usb.git / usb-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-next&id=eaf3074e0a8c2a39c4c14aa8ef1c2ec09ace9c79

Best regards,
Yoshihiro Shimoda