linux-kernel - Re: use generic DMA mapping code in powerpc V4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76bc684a-b4d2-1d26-f18d-f5c9ba65978c@xenosoft.de>
Date:   Thu, 13 Dec 2018 12:19:26 +0100
From:   Christian Zigotzky <chzigotzky@...osoft.de>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-arch@...r.kernel.org,
        Darren Stevens <darren@...vens-zone.net>,
        linux-kernel@...r.kernel.org, Julian Margetson <runaway@...dw.ms>,
        linux-mm@...ck.org, iommu@...ts.linux-foundation.org,
        Paul Mackerras <paulus@...ba.org>,
        Olof Johansson <olof@...om.net>, linuxppc-dev@...ts.ozlabs.org
Subject: Re: use generic DMA mapping code in powerpc V4

On 13 December 2018 at 10:47AM, Christian Zigotzky wrote:
> On 13 December 2018 at 10:10AM, Christoph Hellwig wrote:
>> On Thu, Dec 13, 2018 at 09:41:50AM +0100, Christian Zigotzky wrote:
>>> Today I tried the first patch (0001-get_required_mask.patch) with 
>>> the last
>>> good commit (977706f9755d2d697aa6f45b4f9f0e07516efeda). 
>>> Unfortunately this
>>> patch is already included in the last good commit
>>> (977706f9755d2d697aa6f45b4f9f0e07516efeda). I will try the next patch.
>> Hmm, I don't think this is the case.  This is my local git log output:
>>
>> commit 83a4b87de6bc6a75b500c9959de88e2157fbcd7c
>> Author: Christoph Hellwig <hch@....de>
>> Date:   Wed Dec 12 15:07:49 2018 +0100
>>
>>      get_required_mask
>>
>> commit 977706f9755d2d697aa6f45b4f9f0e07516efeda
>> Author: Christoph Hellwig <hch@....de>
>> Date:   Sat Nov 10 22:34:27 2018 +0100
>>
>>      powerpc/dma: remove dma_nommu_mmap_coherent
>>
>> I've also pushed a git branch with these out to:
>>
>>      git://git.infradead.org/users/hch/misc.git powerpc-dma.5-debug
>>
> Sorry Christioph. I was wrong. The first patch isn't included in the 
> last good commit. I will try it again. I can only test beside my main 
> work. That means it takes longer.
>
> -- Christian
>
>
I tried it again but I get the following error message:

MODPOST vmlinux.o
arch/powerpc/kernel/dma-iommu.o: In function `.dma_iommu_get_required_mask':
(.text+0x274): undefined reference to `.dma_direct_get_required_mask'
make: *** [vmlinux] Error 1