linux-kernel - Re: [PATCH 05/11] staging: iio: adc: ad7606: Add support for threaded irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181213132853.GT3116@kadam>
Date:   Thu, 13 Dec 2018 16:28:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     jic23@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        devel@...verdev.osuosl.org, lars@...afoo.de,
        Michael.Hennerich@...log.com, linux-iio@...r.kernel.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        pmeerw@...erw.net, knaack.h@....de, stefan.popa@...log.co
Subject: Re: [PATCH 05/11] staging: iio: adc: ad7606: Add support for
 threaded irq

On Thu, Dec 13, 2018 at 02:46:17PM +0200, Stefan Popa wrote:
> +static int ad7606_buffer_predisable(struct iio_dev *indio_dev)
> +{
> +	struct ad7606_state *st = iio_priv(indio_dev);
> +	int ret;
> +
> +	reinit_completion(&st->completion);
> +	gpiod_set_value(st->gpio_convst, 1);
> +	ret = wait_for_completion_timeout(&st->completion,
> +					  msecs_to_jiffies(1000));

We don't use this "ret".  It will introduce a set but not used warning
on new GCCs or static checkers or something.

> +	gpiod_set_value(st->gpio_convst, 0);
> +
> +	return iio_triggered_buffer_predisable(indio_dev);
> +}

regards,
dan carpenter