linux-kernel - Re: [PATCH 01/11] staging: iio: adc: ad7606: Simplify the Kconfing menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqLMF=uf5Dcrfz_57KwYK9XDtJamGtf23JiUMDH-F6xa7w@mail.gmail.com>
Date:   Thu, 13 Dec 2018 09:37:57 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Stefan Popa <stefan.popa@...log.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        Stefan Popa <stefan.popa@...log.co>
Subject: Re: [PATCH 01/11] staging: iio: adc: ad7606: Simplify the Kconfing menu

On Thu, Dec 13, 2018 at 8:18 AM Stefan Popa <stefan.popa@...log.com> wrote:
>
> There is no point in having three menu entries that can be selected
> individually. Instead, the SPI and parallel interfaces should select
> AD7606.
>
> Signed-off-by: Stefan Popa <stefan.popa@...log.com>
> ---
>  drivers/staging/iio/adc/Kconfig | 24 +++++++++---------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
> index fc23059..af1bad8 100644
> --- a/drivers/staging/iio/adc/Kconfig
> +++ b/drivers/staging/iio/adc/Kconfig
> @@ -4,35 +4,29 @@
>  menu "Analog to digital converters"
>
>  config AD7606
> -       tristate "Analog Devices AD7606 ADC driver"
> +       tristate
>         depends on GPIOLIB || COMPILE_TEST
>         depends on HAS_IOMEM
>         select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
> -       help
> -         Say yes here to build support for Analog Devices:
> -         ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
> -
> -         To compile this driver as a module, choose M here: the
> -         module will be called ad7606.
>
>  config AD7606_IFACE_PARALLEL
> -       tristate "parallel interface support"
> -       depends on AD7606
> +       tristate "Analog Devices AD7606 ADC driver with parallel interface support"
> +       select AD7606

I don't think this works because the depends on for AD7606 may not be
satisfied. Moving the HAS_IOMEM here would help and either drop
GPIOLIB or move that too.

Rob