linux-kernel - Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdkSSb-EECgCmYnW40Mbd4ibSf22wqUBqaT_X7g7Sn_9UQ@mail.gmail.com>
Date:   Fri, 14 Dec 2018 10:33:51 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

On Fri, Dec 14, 2018 at 12:06 AM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden

-Wstrict-prototypes (plural)

> by -Werror=strict-prototype later.

-Werror=strict-prototypes (plural)

LGTM: https://godbolt.org/z/DyEpmU

If you would mind updating the commit message (and subject), then:
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

>
> Let's add -Werror=strict-prototypes unconditionally because it is
> supported by GCC 4.6, and also by Clang.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  Makefile | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3bbc16a..bcb943e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -423,7 +423,7 @@ LINUXINCLUDE    := \
>                 $(USERINCLUDE)
>
>  KBUILD_AFLAGS   := -D__ASSEMBLY__ -fno-PIE
> -KBUILD_CFLAGS   := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> +KBUILD_CFLAGS   := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
>                    -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
>                    -Werror-implicit-function-declaration \
>                    -Wno-format-security \
> @@ -828,9 +828,6 @@ KBUILD_CFLAGS   += $(call cc-option,-fconserve-stack)
>  # disallow errors like 'EXPORT_GPL(foo);' with missing header
>  KBUILD_CFLAGS   += $(call cc-option,-Werror=implicit-int)
>
> -# require functions to have arguments in prototypes, not empty 'int foo()'
> -KBUILD_CFLAGS   += $(call cc-option,-Werror=strict-prototypes)
> -
>  # Prohibit date/time macros, which would make the build non-deterministic
>  KBUILD_CFLAGS   += $(call cc-option,-Werror=date-time)
>
> --
> 2.7.4
>


-- 
Thanks,
~Nick Desaulniers