linux-kernel - Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Dec 2018 00:31:30 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] kbuild: add -Werror=strict-prototype flag unconditionally

On Sat, Dec 15, 2018 at 3:34 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Fri, Dec 14, 2018 at 12:06 AM Masahiro Yamada
> <yamada.masahiro@...ionext.com> wrote:
> >
> > -Wstrict-prototype is added to KBUILD_CFLAGS first, then overridden
>
> -Wstrict-prototypes (plural)
>
> > by -Werror=strict-prototype later.
>
> -Werror=strict-prototypes (plural)
>
> LGTM: https://godbolt.org/z/DyEpmU
>
> If you would mind updating the commit message (and subject), then:
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>


Thanks for checking this.

I will locally fix those typos (including the one in the subject).



-- 
Best Regards
Masahiro Yamada