linux-kernel - Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in __qdisc_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20181214191144.GP41383@MacBook-Pro-19.local>
Date:   Fri, 14 Dec 2018 11:11:44 -0800
From:   Christoph Paasch <cpaasch@...le.com>
To:     David Miller <davem@...emloft.net>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, bhole_prashant_q7@....ntt.co.jp,
        tyhicks@...onical.com, eric.dumazet@...il.com, edumazet@...gle.com
Subject: Re: [PATCH 4.14 09/89] net: Prevent invalid access to skb->prev in
 __qdisc_drop_all

On 14/12/18 - 11:05:30, David Miller wrote:
> From: Christoph Paasch <cpaasch@...le.com>
> Date: Fri, 14 Dec 2018 07:52:26 -0800
> 
> > I don't think this patch needs to be backported. I haven't hit this panic on
> > v4.14.x (although, I only have been using v4.14.79 for now - not yet the
> > latest one). And the commits that seem to have introduced the issue haven't
> > been backported either AFAICS. That being said, I don't think a backport
> > would cause any side-effects.
> > 
> > Or have you seen reports of this panic in the stable branches?
> > 
> > (same for the other stable branches v4.4,... - cfr., the other mails
> > regarding this patch here)
> 
> I was being ultra paranoid when I decided to submit this to 4.14 too,
> and as Eric says it does not harm.

Sounds good to me. I just wanted to point out that I didn't reproduce the
issue nor tested the patch on the older stable branches.


Christoph